Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OIDC access to KMS key #220

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix OIDC access to KMS key #220

merged 1 commit into from
Jun 28, 2023

Conversation

jesusaurus
Copy link
Contributor

@jesusaurus jesusaurus commented Jun 28, 2023 •
edited by zaro0508
Loading

We should pass in a Role ARN to the key

fix for commit 57b591f

@jesusaurus jesusaurus requested a review from zaro0508 June 28, 2023 17:37
@jesusaurus jesusaurus requested a review from a team as a code owner June 28, 2023 17:37
thomasyu888
thomasyu888 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@zaro0508 zaro0508 merged commit c302788 into Sage-Bionetworks-Workflows:dev Jun 28, 2023
5 checks passed
@zaro0508 zaro0508 mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaro0508 zaro0508 zaro0508 approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesusaurus @zaro0508 @thomasyu888