Remove GH service role #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have switch to using a github OIDC role thus we no longer need the service role.
thomasyu888
approved these changes
Jun 28, 2023
|
i'm not aware of any other impacts, ohh we'll probably want to remove aws secrets from github after merging. |
jesusaurus
approved these changes
Jun 29, 2023
zaro0508
added a commit
to Sage-Bionetworks-IT/organizations-infra
that referenced
this pull request
Jul 3, 2023
The CI service user is being replaced with GH OIDC access. depends on Sage-Bionetworks-Workflows/nextflow-infra#215 Sage-Bionetworks-Workflows/nextflow-infra#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have switch to using a github OIDC role thus we no longer need the service role.