[IT-2968] Revert IT-2360 due to ampad deployment failure #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
approved these changes
Jun 29, 2023
zaro0508
commented
Jun 29, 2023
| @@ -25,4 +25,3 @@ TOWER_OIDC_TOKEN_IMPORT: "!If [ HasTowerOidcClient, !Ref TowerOidcTokenImport, ! | |||
| TOWER_ROOT_USERS: "!If [ HasTowerRootUsers, !Join [',', !Ref TowerRootUsers], !Ref AWS::NoValue]" | |||
| TOWER_USER_WORKSPACE_ENABLED: "!Ref 'TowerUserWorkspace'" | |||
| TOWER_CONFIG_FILE: "!Sub '${EfsVolumeMountPath}/${TowerConfigFileName}'" | |||
| TOWER_ALLOW_INSTANCE_CREDENTIALS: "true" | |||
There was a problem hiding this comment.
should this be reverted as well @thomasyu888 ? or should it be kept in place?
There was a problem hiding this comment.
We can remove for now. Lets add it back in later
zaro0508
added a commit
to zaro0508/nextflow-infra
that referenced
this pull request
Jul 4, 2023
This is a 2nd attempt at PR Sage-Bionetworks-Workflows#205 which was reverted in PR Sage-Bionetworks-Workflows#226 We need to make the shared role into a common resource so that it gets deployed to all accounts which will make the resource available to tower project templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change that caused ampad project deployments to fail.
We will need to figure out a different solution and try again.