Add Sasha to jhu-biobank-nf-project.yaml #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Sasha to the project
thomasyu888
requested changes
Jul 18, 2023
There was a problem hiding this comment.
@jaybee84 I have no idea the impact of this change.
What I worry about is if the workspace gets deleted and a new workspace gets created and you lose all the data.
I suggest not renaming the workspace for now since this is time sensitive.
|
@thomasyu888 sorry for the confusion. This is an old defunct workspace that we are reviving. I changed the name to avoid the exact kind of confusion that this PR has caused I think.
|
thomasyu888
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @ajs3nj