Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): allow disable timestamp on terminal logs #1391

Open
wants to merge 5 commits into
base: dev-next
Choose a base branch
from

Conversation

mritd
Copy link

@mritd mritd commented Jan 22, 2024

allow disable timestamp on terminal logs

nekohasekai and others added 5 commits January 17, 2024 05:50
The `process_path` rule of sing-box is inherited from Clash,
the original code uses the local system's path format (e.g. `\Device\HarddiskVolume1\folder\program.exe`),
but when the device has multiple disks, the HarddiskVolume serial number is not stable.

This change make QueryFullProcessImageNameW output a Win32 path (such as `C:\folder\program.exe`),
which will disrupt the existing `process_path` use cases in Windows.
For historical reasons, sing-box's `domain_suffix` rule matches literal prefixes instead of the same as other projects.

This change modifies the behavior of `domain_suffix`: If the rule value is prefixed with `.`,
the behavior is unchanged, otherwise it matches `(domain|.+\.domain)` instead.
allow disable timestamp on terminal logs

Signed-off-by: kovacs <[email protected]>
@nekohasekai nekohasekai force-pushed the dev-next branch 9 times, most recently from 82269a4 to 1bc83a1 Compare June 22, 2024 06:16
@nekohasekai nekohasekai force-pushed the dev-next branch 11 times, most recently from b34153f to 6da5ed4 Compare June 27, 2024 13:22
@nekohasekai nekohasekai force-pushed the dev-next branch 10 times, most recently from 07b192a to 06ee404 Compare July 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants