Teams: move warning to debug message for config_mask==0 and config == null #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dalcinl
approved these changes
Jun 24, 2024
mrogowski
approved these changes
Jun 24, 2024
wrrobin
reviewed
Jun 24, 2024
stewartl318
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1122, this warning may not be necessary, especially with some upcoming proposed changes to the specification to clarify this special case.
For now this PR changes this to a debug message, so at least users will not see any message unless the env var
SHMEM_DEBUG=1is set.I could likely be convinced to remove this message entirely, but given the state of the OpenSHMEM v1.5 spec, which is unclear as to whether a null
configargument is acceptable, a debug message might be a better "compromise".@dalcinl @stewartl318 @mrogowski - I invited you as collaborators to review, you'll need to accept it in email.