Additional error checking on API calls; See #12 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the tests are failing because the mocked responses aren't including a the |
|
Canceling this PR as the API tests don't consistently include mocked |
…s_code so unclear where to go with this; README addition for running tests
|
FYI, @teleyinex. This might resolve #12 / #47 |
|
This looks good! Please sign the CONTRIBUTION agreement and we will merge it! |
|
Apologies for the really long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the payload contains a
statusattribute since existing code doesn't properly handle failure (i.e., assumes success if it doesn't see the failure it expects)