Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add support to action registration #169

Merged
merged 11 commits into from
Aug 3, 2023
Merged

refactor: Add support to action registration #169

merged 11 commits into from
Aug 3, 2023

Conversation

RodolfoSilva
Copy link
Contributor

@RodolfoSilva RodolfoSilva commented Jul 15, 2023 •
edited
Loading

Description

Added support for registering custom actions in the registry and refactored the existing actions to have the new format.

Related Issues

The dicussion has started in the PR #110 and closes the issue #50 and the discussion #120.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@RodolfoSilva
Copy link
Contributor Author

@i-asimkhan I believe this will address what we discussed in #110, enabling the registration of custom actions.

@RodolfoSilva RodolfoSilva mentioned this pull request Jul 15, 2023
Open
7 tasks
@i-asimkhan i-asimkhan added the enhancement New feature or request label Jul 17, 2023
@i-asimkhan
Copy link
Contributor

@RodolfoSilva Thanks for this. Just have a look at the crashing PR Checks.

@i-asimkhan I believe this will address what we discussed in #110, enabling the registration of custom actions.

i-asimkhan
i-asimkhan reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this immensely impt refactoring, please check my comments. Thanks

packages/mirai/lib/src/framework/mirai.dart Show resolved Hide resolved
packages/mirai/lib/src/parsers/mirai_elevated_button/mirai_elevated_button.dart Outdated Show resolved Hide resolved
packages/mirai/lib/src/parsers/mirai_floating_action_button/mirai_floating_action_button.dart Outdated Show resolved Hide resolved
packages/mirai/lib/src/parsers/mirai_icon_button/mirai_icon_button.dart Outdated Show resolved Hide resolved
packages/mirai/lib/src/parsers/mirai_list_tile/mirai_list_tile.dart Outdated Show resolved Hide resolved
packages/mirai/lib/src/parsers/mirai_text_button/mirai_text_button.dart Outdated Show resolved Hide resolved
docs/docs/basics/parsers.md Outdated Show resolved Hide resolved
docs/docs/basics/parsers.md Outdated Show resolved Hide resolved
docs/docs/basics/parsers.md Outdated Show resolved Hide resolved
docs/docs/basics/parsers.md Outdated Show resolved Hide resolved
@RodolfoSilva
Copy link
Contributor Author

@RodolfoSilva Thanks for this. Just have a look at the crashing PR Checks.

@i-asimkhan I believe this will address what we discussed in #110, enabling the registration of custom actions.

Thanks @i-asimkhan.

I've resolved all comments and fixed all crashes reported by PR Checks:

flutter analyze
dart format --set-exit-if-changed .

i-asimkhan
i-asimkhan reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@i-asimkhan i-asimkhan self-requested a review July 18, 2023 07:46
i-asimkhan
i-asimkhan requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyanshub024 Please have a look

@RodolfoSilva
Copy link
Contributor Author

@i-asimkhan @divyanshub024 any updates on this PR?

@divyanshub024
Copy link
Contributor

Hey @RodolfoSilva!! Sorry for bit delay. I'm on vacation and traveling a lot these days. I'll try to review and merge your PR soon.

@RodolfoSilva
Copy link
Contributor Author

Oh sorry, have a nice vacation @divyanshub024. I hope you are enjoying this time.

divyanshub024
divyanshub024 suggested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RodolfoSilva !!

I wanted to start by expressing my gratitude for your incredible pull request. This PR is bound to have a significant impact on the Mirai framework, opening up numerous possibilities for creating custom actions and triggers. Fantastic work! 💯

I have some minor suggestions. Please check them.

packages/mirai/lib/src/parsers/mirai_actions/mirai_actions.dart Outdated Show resolved Hide resolved
...es/mirai/lib/src/parsers/mirai_actions/mirai_request_action/mirai_request_action_parser.dart Outdated Show resolved Hide resolved
divyanshub024
divyanshub024 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@divyanshub024 divyanshub024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this amazing PR @RodolfoSilva 💯

@divyanshub024 divyanshub024 added this to the v0.5 milestone Aug 3, 2023
i-asimkhan
i-asimkhan approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@i-asimkhan i-asimkhan merged commit eb59b53 into Securrency-OSS:main Aug 3, 2023
2 checks passed
@RodolfoSilva RodolfoSilva deleted the refactor/split-actions branch August 3, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-asimkhan i-asimkhan i-asimkhan approved these changes

@divyanshub024 divyanshub024 divyanshub024 approved these changes

Assignees

@RodolfoSilva RodolfoSilva

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RodolfoSilva @i-asimkhan @divyanshub024