fix(action): set entrypoint type to string #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the action.yaml file to pass the `entrypoint` parameter as a single string, rather than a sequence of arguments. act expects the entrypoint to be of type string[]. However, the GitHub runner expects type string. Because of this disconnect, workflow files that pass their act tests throw exceptions when ran on GitHub hosted runners, and vice-versa. To work around this issue, the act JUnit tests have been temporarily ignored until this issue can be resolved. To see the entrypoint parser in act, see https://git.io/JJZx0 To see the entrypoint parter in the GH runner, see https://git.io/JJZxV Associated issue: #26
|
🎉 This PR is included in version 1.0.1-develop.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ShahradR
added a commit
that referenced
this pull request
Nov 29, 2020
feat: add Dependabot support to the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the action.yaml file to pass the
entrypointparameter as a single string, rather than a sequence of arguments.act expects the
entrypointto be of typestring[]. However, the GitHub runner expects typestring. Because of this disconnect, workflow files that pass their act tests throw exceptions when ran on GitHub hosted runners, and vice-versa.To work around this issue, the act JUnit tests have been temporarily ignored until this issue can be resolved.
To see the entrypoint parser in act, see https://git.io/JJZx0
To see the entrypoint parter in the GH runner, see https://git.io/JJZxV
Associated issue: #26