Implemented Proper log handling #79
rust-fmt.yml
on: pull_request
Run rustfmt style commit
21s
Annotations
5 warnings
Run rustfmt style commit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, stefanzweifel/git-auto-commit-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
variants `InterfaceNotFound`, `ArgumentParseError`, `ModeNotSupported`, and `NetworkError` are never constructed:
src/main.rs#L32
warning: variants `InterfaceNotFound`, `ArgumentParseError`, `ModeNotSupported`, and `NetworkError` are never constructed
--> src/main.rs:32:5
|
31 | enum FluereError {
| ----------- variants in this enum
32 | InterfaceNotFound,
| ^^^^^^^^^^^^^^^^^
33 | DeviceError(DeviceError),
34 | ArgumentParseError(String),
| ^^^^^^^^^^^^^^^^^^
35 | ModeNotSupported(String),
| ^^^^^^^^^^^^^^^^
36 | NetworkError(String),
| ^^^^^^^^^^^^
|
= note: `FluereError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
this function has too many arguments (27/7):
fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7)
--> fluereflow/src/types/fluereflow.rs:63:5
|
63 | / pub fn new(
64 | | source: IpAddr,
65 | | destination: IpAddr,
66 | | d_pkts: u32,
... |
90 | | tos: u8,
91 | | ) -> FluereRecord {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
returning the result of a `let` binding from a block:
fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block
--> fluere-config/src/init.rs:98:5
|
97 | let path_config = path_base.join("fluere");
| ------------------------------------------- unnecessary `let` binding
98 | path_config
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
97 ~
98 ~ path_base.join("fluere")
|
|
unneeded unit expression:
fluere-config/src/init.rs#L25
warning: unneeded unit expression
--> fluere-config/src/init.rs:25:21
|
25 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
|