Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "can be builtin" setting to ProcDirective #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "can be builtin" setting to ProcDirective #217

wants to merge 1 commit into from

Conversation

spookydonut
Copy link
Collaborator

Fixes #202

@SpaceManiac
Copy link
Owner

Do we need to afford special status to builtins here? Can we simply say these lint settings "must be on the declaration" or not?

@spookydonut
Copy link
Collaborator Author

Do we need to afford special status to builtins here? Can we simply say these lint settings "must be on the declaration" or not?

@SpaceManiac maybe just allow compatible lints on built-ins regardless?

@SpaceManiac
Copy link
Owner

@spookydonut why does "built-in-ness" matter at all? Are there lints that don't work if they go on overrides rather than /proc/ declarations?

@SpaceManiac SpaceManiac changed the title Add can be builtin Add "can be builtin" setting to ProcDirective Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

would be nice to be able to use stuff like SHOULD_NOT_SLEEP on builtin procs
2 participants
@spookydonut @SpaceManiac