Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redirecting URLs in bundled library metadata #793

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 20, 2023

The url field of the library.properties metadata file points the user to where they might find more information or assistance for the library.

This platform includes bundled libraries which are variants of the standardized libraries distributed by Arduino. The url field in the metadata of these libraries points to the reference on the arduino.cc website, as that information is also applicable to this platform's variants of the libraries.

Due to restructuring of the arduino.cc website, the targeted reference pages have moved to a different URL. Arduino set up redirects from the previous URLs to the new one, but redirects have a tendency to break or no longer lead to the intended target over time so it is best to avoid relying on them. In addition, the use of redirecting URLs seems to make it more likely that automated link checks will fail (per1234/arduino-ci-script#33) due to an HTTP 403 ("Forbidden") response code:

https://github.com/SpenceKonde/ATTinyCore/actions/runs/5339900593/jobs/9679095711

ERROR: /home/runner/work/ATTinyCore/ATTinyCore/avr/libraries/Wire/library.properties: url value http://www.arduino.cc/en/Reference/Wire returned error status 403.

even though the URL does work as expected when a human loads it in their browser:

http://www.arduino.cc/en/Reference/Wire

The `url` field of the `library.properties` metadata file points the user to where they might find more information or
assistance for the library.

This platform includes bundled libraries which are variants of the standardized libraries distributed by Arduino. The
`url` field in the metadata of these libraries points to the reference on the arduino.cc website, as that information is
also applicable to this platform's variants of the libraries.

Due to restructuring of the arduino.cc website, the targeted reference pages have moved to a different URL. Arduino set
up redirects from the previous URLs to the new one, but redirects have a tendency to break or no longer lead to the
intended target over time so it is best to avoid relying on them. In addition, the use of redirecting URLs seems to make
it more likely that automated link checks will fail due to an HTTP 403 ("Forbidden") response code, even though the URL
does work as expected when a human loads it in their browser.
@SpenceKonde SpenceKonde merged commit 1747efb into SpenceKonde:v2.0.0-devThis-is-the-head-submit-PRs-against-this Jul 20, 2023
45 of 55 checks passed
@SpenceKonde
Copy link
Owner

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants