Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for broken I2C functionality on x41 chips #843

Open
wants to merge 1 commit into
base: v2.0.0-devThis-is-the-head-submit-PRs-against-this
Choose a base branch
from
Open

Fix for broken I2C functionality on x41 chips #843

wants to merge 1 commit into from

Conversation

ahshah
Copy link

@ahshah ahshah commented Feb 16, 2024 

- CLK/SDA Pins are swapped and comments are misleading
- Pin swap Discussion can be viewed here:
    https://github.com/SpenceKonde/ATTinyCore/discussions/833
- Fix recursive call: Wire.cpp in soft master / hw slave
- SoftI2CMaster.h has some interesting code changes that I can't make heads or tails of. They also break software master functionality, changes proposed here get things working again.
- Improved some indentation and grammar

Fix for broken I2C functionality on x41 chips
dda3c5a 
    - CLK/SDA Pins are swapped and comments are misleading
    - Pin swap Discussion can be viewed here:
        SpenceKonde#833
    - Fix recursive call: Wire.cpp in soft master / hw slave
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ahshah