Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgrange/fix_vulnerabilities_signaled_by_github (again) #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dejafait
Copy link
Contributor

@dejafait dejafait commented Sep 2, 2019

second attempt after 404 fiasco of first attempt #400

@dejafait dejafait changed the title vgrange/fix_vulnerabilities_signaled_by_github vgrange/fix_vulnerabilities_signaled_by_github (again) Sep 2, 2019
@dejafait
Copy link
Contributor Author

dejafait commented Sep 2, 2019

FTR

https://valodata.slack.com/archives/C2RR5PZD3/p1567414270000500

OK en recette

KO en production, toutes les pages donnent cette 404 :-(

image

Pourtant en fin de deploy du frontal 1, les URLs frontend ont été testées et renvoyaient bien une 200! o_O Normalement le deploy aurait du casser à cette étape, ainsi le frontal 1 reste HS tandis que le frontal 2 non mis à jour continue de servir 100% du traffic.

image

@dejafait
Copy link
Contributor Author

dejafait commented Sep 2, 2019

@dejafait dejafait self-assigned this Sep 13, 2019
Mainly upgrade Flask to 1.1.1
logging.DEBUG_LOG_FORMAT no longer exists, I dropped it as it is
only used in development and I have no idea why we needed it.
@dejafait dejafait force-pushed the vgrange/fix_vulnerabilities_signaled_by_github branch from 341e38a to 675b0b4 Compare January 3, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant