Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename ar-AR.json to ar-SA.json #604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rex07
Copy link
Contributor

@rex07 rex07 commented Jan 8, 2023

No description provided.

@jaruba
Copy link
Member

jaruba commented Feb 8, 2023

changing the name of a translation file will cause issues for users, if they selected this language before it will not load it anymore due to the file name change

@rex07
Copy link
Contributor Author

rex07 commented Feb 8, 2023

There is no AR region in Arabic languages the AR display argentina in the app which is not an arabic contry.

http://www.lingoes.net/en/translator/langcode.htm

@jaruba
Copy link
Member

jaruba commented Feb 8, 2023

the code of this language is associated with this string in the apps:
Screenshot 2023-02-08 at 15 41 16

if this file is changed from ar-AR to ar-SA, then all users that ever selected this language will no longer have it selected, as ar-AR is no longer available

@rex07
Copy link
Contributor Author

rex07 commented Feb 8, 2023

The android tv app display
Screenshot-20230208-172408-Bugjaeger-Premium-1.png
العربية(الأرجنتين)
Arabic (argentina)

@jaruba
Copy link
Member

jaruba commented Feb 8, 2023

in mobile and desktop app it is what i screenshot above, and changing the name of this file will break the language choice of everyone that ever chose that language in all apps..

@rex07
Copy link
Contributor Author

rex07 commented Feb 8, 2023

OK, I see, all I have to do now is create a new file called ar-sa.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants