Ethan/thermocouple #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in proper SPI for thermocouple in main_avionics as SystemDefines created and started writing thermocouple task
EtSubas
commented
May 20, 2023
Jgerbrandt
reviewed
May 20, 2023
…paceResearch/PlumbingBayBoard into ethan/thermocouple
|
Just a note: have to update telemetry task to request both a new sample and transmit for PT/TC. |
Matt4890
reviewed
Jun 17, 2023
There was a problem hiding this comment.
A lot of styling inconsistencies/concerns, however that may not be critical. Be careful of magic numbers (i.e., just raw decimal numbers that aren't trivial). Instead, create a define/constexpr with a descriptive name and use that. This drastically improves code clarity and readability.
Otherwise, the functionality seems okay. Because of the massive architecture shift, I don't feel comfortable confirming that nothing is missing, so a super quick lookover from Chris/etc. would be nice.
Ensure that everything is functional before submitting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding in thermocouple task code along with debug info