fix bug 1058 #1067
fix bug 1058 #1067
Conversation
|
Code Climate has analyzed commit ea1cfcb and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| import static swati4star.createpdf.util.Constants.PDF_TO_IMAGES; | ||
| import static swati4star.createpdf.util.Constants.REQUEST_CODE_FOR_WRITE_PERMISSION; | ||
| import static swati4star.createpdf.util.Constants.WRITE_PERMISSIONS; | ||
|
|
There was a problem hiding this comment.
Revert these unnecessary changes! (Any beautification work should be done in separate commit may or may not in single pull request)
| import com.afollestad.materialdialogs.MaterialDialog; | ||
| import com.airbnb.lottie.LottieAnimationView; | ||
| import com.dd.morphingbutton.MorphingButton; | ||
| import com.google.android.material.bottomsheet.BottomSheetBehavior; |
There was a problem hiding this comment.
[I repeat] Any beautification work should be done in separate commit may or may not in single pull request.
| @@ -12,6 +13,7 @@ | |||
| import android.print.PrintDocumentAdapter; | |||
| import android.print.PrintManager; | |||
| import android.provider.MediaStore; | |||
|
|
|||
There was a problem hiding this comment.
[I repeat] Any beautification work should be done in separate commit may or may not in single pull request.
| @@ -108,7 +110,6 @@ private void shareFile(ArrayList<Uri> uris) { | |||
| * opens a file in appropriate application | |||
| * | |||
| * @param path - path of the file to be opened | |||
| * | |||
| */ | |||
There was a problem hiding this comment.
[I repeat] Any beautification work should be done in separate commit may or may not in single pull request.
| * @param ext the file extension | ||
| * @param saveMethod the method that should be called when a filename is chosen | ||
| * @param ext the file extension | ||
| * @param saveMethod the method that should be called when a filename is chosen | ||
| */ |
|
Can you fix merge conflicts? |
Description
Modify PdfToImageFragment.java: In method onImagesInGalleryClick(), the original image URI is an invalid and fixed URI "content:///storage/emulated/0/PDFfiles/". I replace this URI with the URI of the generated image, and create an util method file2Content in FileUtils.java to convert URI starts with"file://" to URI starts with "content://", and then save the images to the gallery.
Now "view images in gallery" button can show generated images in gallery.
Fixes #1058
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Tested on Pixel 2 API 30 in Android Studio
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: