Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1101: Scan QR code from saved picture #1143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liammaloney2403
Copy link

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are
required for this change.
If there are any UI change, please include the screenshots also.

Fixes #1101

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

UI screenshots:
Screen Shot 2023-10-22 at 4 29 21 pm
Screen Shot 2023-10-22 at 4 29 40 pm

@codeclimate
Copy link

codeclimate bot commented Oct 22, 2023

Code Climate has analyzed commit bdf11ab and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4

View more on Code Climate.

<menu xmlns:android="http://schemas.android.com/apk/res/android">
<item
android:id="@+id/camera"
android:title="Take a photo of code" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use strings.xml string instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan QR code from saved picture
2 participants