prevent runaway row loading

Synphonyte · Feb 20, 2024 · 1da8ee0 · 1da8ee0
1 parent 9d1ad1b
commit 1da8ee0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.8.3] - 2024-02-20
+
+### Fix 🐛
+
+- When not limiting a scroll container this could lead to a runaway row loading. This is now limited to max 500 rows.
+
 ## [0.8.2] - 2024-02-18
 
 ### Feature 🚀

diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "leptos-struct-table"
-version = "0.8.2"
+version = "0.8.3"
 edition = "2021"
 authors = ["Marc-Stefan Cassola"]
 categories = ["gui", "web-programming"]

diff --git a/src/components/table_content.rs b/src/components/table_content.rs
@@ -24,6 +24,8 @@ use std::rc::Rc;
 use wasm_bindgen::JsCast;
 use web_sys::Element;
 
+const MAX_DISPLAY_ROW_COUNT: usize = 500;
+
 renderer_fn!(
     RowRendererFn<Row>(
         class: Signal<String>,
@@ -368,6 +370,8 @@ where
             end = end.min(row_count);
         }
 
+        end = end.min(start + MAX_DISPLAY_ROW_COUNT);
+
         loaded_rows.update_untracked(|loaded_rows| {
             if end > loaded_rows.len() {
                 loaded_rows.resize(end);