Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression support boolean to fix #152 #158

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Conversation

lixingwang
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

[*] Bugfix
[] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

Fixes: #152
What is the current behavior?
Does not support this case: string.equals("sea", "sea") == true or isDefined($activity[rest_2].result.photoUrlz) != false
What is the new behavior?
Support expression like: isDefined($activity[rest_2].result.photoUrlz) != false or string.equals("seafood,name", "sea") == false

@lixingwang lixingwang merged commit e94cc6d into master Apr 5, 2018
@lixingwang lixingwang deleted the expression_boolean branch April 5, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants