Refactor(utils): Ensure consistent declaration style of utility functions and standardize parameters for the sleep method #7554
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated this one to match.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 87306cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87306cb:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7554 +/- ##
===========================================
+ Coverage 43.87% 62.25% +18.38%
===========================================
Files 184 124 -60
Lines 7027 4478 -2549
Branches 1534 1233 -301
===========================================
- Hits 3083 2788 -295
+ Misses 3578 1459 -2119
+ Partials 366 231 -135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that most functions within the
packages/*/src/utils.tsandpackages/*/src/__tests__/utils.tsfiles were declared as regular functions, so I made consistent adjustments.While most were already in this format, I found a few arrow functions and updated them accordingly (It doesn't seem to be using the 'this").
Additionally, I noticed inconsistency in the parameters of the sleep function, where some used timeout while others used ms, so I unified them all to ms.