Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of misc fixes for the ci, with the aim of making it pass for mostly ok commits (with a few exceptions, see below).
In order to do this I have had to remove the shared build from msys, and the tls build from msvc. I did try to get the msvc build working but I think it may just be too much for the memory of the vm (resources required to compile possibly should be something we look at, but its not something I know much about in terms of optimisation).
The mingw build seems to be just borked completely in shared mode, I have no idea what the issue is there and any attempts to debug it are proving pointless (at least for me, the point of hanging even changes randomly it seems). My best guess is its something to do with the dynamic loading of the different parts of malloy but thats just a wild guess based on the fact it only happens in the shared build.
I believe removing these are ok because they always failed anyway no matter the content of the commit and thus didn't actually provide anything useful in terms of checks, #89 is still an issue though and we might want to open a tracking issue for the msvc stuff.
Other changes: msys/clang -> msys/mingw