Fix Aether parachutes causing permanent crash 馃獋 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the player falls out of the Aether dimension with a parachute equipped, when re-entering the Aether the parachute is still there and due to being marked as being mounted with the player, causes a crash preventing the Aether from being entered again. This commit causes parachutes to despawn when they get below y=0, and also lowers the height in which the player will 'fall out of' the Aether. (gives the parachute more time to despawn and also it's really annoying flying in creative falling at y<-2) Code from Departure, I'm just the git gremlin Signed-off-by: Richard Rogalski <[email protected]> Co-authored-by: Wojak <[email protected]>
|
The reason above is not correct, this occurred when the player fell out of the aether leaving the parachute entity as they are dismounted from it there without despawning it, upon return it was still there and the game did not know how to handle it's AI but it also immediately despawns it but the AI issue still causes a crash to desktop on client/server. It hard crashed the client and server but be fine when you reloaded as it would of despawned. This is my best understanding to why the crash occurred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the player falls out of the Aether dimension with a parachute equipped, when re-entering the Aether the parachute is still there and due to being marked as being mounted with the player, causes a crash preventing the Aether from being entered again.
This commit causes parachutes to despawn when they get below y=0, and also lowers the height in which the player will 'fall out of' the Aether. (gives the parachute more time to despawn and also it's really annoying flying in creative falling at y<-2)
Code from Departure, I'm just the git gremlin
I agree to the Contributor License Agreement (CLA).