Skip to content

Commit

Permalink
Fixing github actions step dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
bergsalex committed Jun 5, 2024
1 parent d730ca6 commit 8bd8892
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:
# required-coverage: ${{ vars.REQUIRED_COVERAGE }}
build:
name: "Build: Dev"
needs: [test, check-coverage]
# TODO: Uncomment the following lines when we have the previous steps
# needs: [test, check-coverage]
uses: ./.github/workflows/_skaffold-build-k8s.yml
secrets: inherit
with:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ jobs:
# python-version: ${{ matrix.python-version }}
# required-coverage: ${{ vars.REQUIRED_COVERAGE }}
version:
needs: test
# TODO: Uncomment the following lines when we have the previous steps
# needs: test
runs-on: ubuntu-latest
outputs:
should_release: ${{ steps.version_check.outputs.should_release }}
Expand Down Expand Up @@ -98,7 +99,9 @@ jobs:
build:
name: "Build"
needs: [ test, check-coverage, format-lint, version ]
# TODO: Replace with the commented line when we have a test step.
# needs: [ test, check-coverage, format-lint, version ]
needs: [ check-coverage, format-lint, version ]
if: ${{ needs.version.outputs.should_release == 'true' }}
uses: ./.github/workflows/_skaffold-build-k8s.yml
secrets: inherit
Expand Down

0 comments on commit 8bd8892

Please sign in to comment.