Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autogenerate/prefill gateway and device ID in the console #7156

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

PavelJankoski
Copy link
Contributor

Summary

References #7063

Changes

  • Remove logic that autogenerates/prefills gateway ID.
  • Remove logic that autogenerates/prefills device ID.
  • Modify/update related messages.
  • Update related tooltips.

Testing

Steps
  • For gateway:
  1. Login to console.
  2. Navigate to gateways screen.
  3. Click on register gateway.
  4. Type in gateway EUI.
  5. The gateway ID should not be prefilled.
  • For end device:
  1. Login to console.
  2. Navigate to applications screen.
  3. Select an application.
  4. Click on register end device.
  5. The gateway ID should not be prefilled.
  6. Select "Enter end device specifics manually" radio button.
  7. Fill in the required fields along with JoinEUI.
  8. The device ID should not be prefilled.
Results
  • For gateway:
Screen.Recording.2024-06-25.at.00.40.05.mov
  • For end device:
Screen.Recording.2024-06-25.at.00.41.55.mov

Notes for Reviewers

Check the messages and tooltips if the text needs to be changed.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added this to the Jun 2024 milestone Jun 24, 2024
@PavelJankoski PavelJankoski self-assigned this Jun 24, 2024
@PavelJankoski PavelJankoski requested a review from a team as a code owner June 24, 2024 22:50
@github-actions github-actions bot added the ui/web This is related to a web interface label Jun 24, 2024
@KrishnaIyer
Copy link
Member

Thanks a lot @PavelJankoski. This will really reduce the number of support requests/questions. Indeed the Tooltips need update.

Gateway

Current
Screenshot 2024-06-26 at 10 04 17
Proposal

A mandatory identifier for your gateway using lowercase letters, numbers and dashes. This value must be unique per tenant and is not related to the Gateway's EUI.

End Device

Current
Screenshot 2024-06-26 at 10 04 53
Proposal

A mandatory identifier for your end device using lowercase letters, numbers and dashes. This value must be unique within an application.

@kschiffer
Copy link
Member

Please see my comment on the general issue here:
#7063 (comment)

I'm sorry I'm bringing this up late in the game but please let's discuss this.

@kschiffer
Copy link
Member

kschiffer commented Jun 27, 2024

Ok so concluding the discussion in #7063, we will stick with not doing any autofill.

Here's my slightly extended suggestion for the gateway tooltip.

What is this?
A mandatory identifier for your gateway that must be unique per network and cannot be changed after creation. It is used to reference your end device e.g. in events, webhooks end API requests.
What should I enter here?
Enter a value using lowercase letters, numbers, and dashes. You can choose this freely.

And the end device tooltip:

What is this?
A mandatory identifier for your end device that must be unique within the application and cannot be changed after creation. It is used to reference your end device e.g. in events, webhooks end API requests.
What should I enter here?
Enter a value using lowercase letters, numbers, and dashes. You can choose this freely.

Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@KrishnaIyer KrishnaIyer modified the milestones: Jun 2024, v3.31.1 Jul 1, 2024
@PavelJankoski PavelJankoski force-pushed the feature/7063-do-not-prefill-id branch 2 times, most recently from 2705c38 to 387c7d9 Compare July 3, 2024 12:23
Copy link
Member

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End to end tests need an update here as well.

@PavelJankoski PavelJankoski force-pushed the feature/7063-do-not-prefill-id branch 4 times, most recently from 0f3b60b to 5d0f04c Compare July 4, 2024 12:48
@PavelJankoski PavelJankoski force-pushed the feature/7063-do-not-prefill-id branch from 766b76c to 9466fef Compare July 4, 2024 13:07
@PavelJankoski PavelJankoski merged commit afb8f16 into v3.31 Jul 4, 2024
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the feature/7063-do-not-prefill-id branch July 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants