Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nbtrans overrides validation schema #7170

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Jul 2, 2024

Summary

References this https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1071#issuecomment-2191996617

Changes

  • Fix validation schema to allow empty values

Testing

Steps

Update NbTrans values using the below CLI commands:

ttn-lw-cli dev set nb-trans-test eui-0004a30b001bc9bb --mac-settings.adr.mode.dynamic.overrides.data-rate-5.max-nb-trans 3
ttn-lw-cli dev set nb-trans-test eui-0004a30b001bc9bb --mac-settings.adr.mode.dynamic.overrides.data-rate-3.min-nb-trans 2
ttn-lw-cli dev set nb-trans-test eui-0004a30b001bc9bb --mac-settings.adr.mode.dynamic.overrides.data-rate-1.min-nb-trans 2 --mac-settings.adr.mode.dynamic.overrides.data-rate-5.max-nb-trans 3
Results

The network layer page should not crash:

Screenshot 2024-07-02 at 11 57 50

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Jul 2, 2024
@ryaplots ryaplots added this to the v3.31.1 milestone Jul 2, 2024
@ryaplots ryaplots self-assigned this Jul 2, 2024
@ryaplots ryaplots requested a review from a team as a code owner July 2, 2024 09:58
@ryaplots ryaplots merged commit c53fc4f into v3.31 Jul 4, 2024
12 of 13 checks passed
@ryaplots ryaplots deleted the fix/nbtrans-validation-schema branch July 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants