Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing milestone #7174

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Ignore missing milestone #7174

merged 1 commit into from
Jul 4, 2024

Conversation

happyRip
Copy link
Member

@happyRip happyRip commented Jul 4, 2024

Summary

Cherry-picks from https://github.com/TheThingsIndustries/lorawan-stack/pull/4279

Changes

  • Add logic to ignore missing/closed milestone when creating a PR.

Testing

Tested on TTI.

Notes for Reviewers

nil

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@happyRip happyRip added this to the v3.31.1 milestone Jul 4, 2024
@happyRip happyRip self-assigned this Jul 4, 2024
@happyRip happyRip requested a review from a team as a code owner July 4, 2024 12:28
@happyRip happyRip requested a review from KrishnaIyer July 4, 2024 12:28
@happyRip happyRip merged commit b15cafb into v3.31 Jul 4, 2024
2 of 3 checks passed
@happyRip happyRip deleted the issue/ignore-missing-milestone branch July 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants