Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce fairness #94

Merged
merged 9 commits into from
Jul 8, 2024
Merged

feat: introduce fairness #94

merged 9 commits into from
Jul 8, 2024
+1,410 −193

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jun 26, 2024

No description provided.

@triceo triceo mentioned this pull request Jun 27, 2024
Merged
@triceo triceo marked this pull request as ready for review July 1, 2024 05:37
@triceo triceo mentioned this pull request Jul 1, 2024
Closed
Christopher-Chianelli
Christopher-Chianelli requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for load_balance.

timefold-solver-python-core/src/main/python/score/_group_by.py Outdated Show resolved Hide resolved
Christopher-Chianelli
Christopher-Chianelli requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for new verifier methods; other than that, LGTM

tests/test_constraint_verifier.py Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
48.2% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

Christopher-Chianelli
Christopher-Chianelli approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_balance would need to become more Pythonic, but that depends on the Decimal type + consecutive_sequences also needs a rework. LGTM.

@triceo triceo merged commit e1dac95 into TimefoldAI:main Jul 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@triceo @Christopher-Chianelli