Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Greek Locale for portal,comments,ghost and signup-form #20277

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nikostzoras
Copy link

Hey, I just added the Greek locale for Ghost. There is an error, but I can't understand why.
The translations are 99% accurate, and I'm pretty confident that all users will understand every text displayed. Some changes could be made to shorten the sentences, but I think this is a great start.

@royalfig
Copy link
Contributor

Hi @nikostzoras, thanks for the contribution!

Unfortunately, the folder name, greek, isn't right. You need to use the ISO language code. Please update the folder name and then we can merge the changes.

@nikostzoras
Copy link
Author

This is my first time using GitHub and I have no idea what I'm doing. I managed to translate Ghost following the instructions from the official Ghost youtube channel. How can I edit the files ? Thanks for your time and patience

Copy link
Contributor

Note from our bot: Some changes have been requested on this pull request. Updating your code is great, but won't notify us, so please leave a comment so that we (and our bot) can see when you've made the changes. Thank you 🙏

@amirsaam
Copy link
Contributor

@nikostzoras you need to name your folder el and add this code to ghost/i18n/lib/i18n.js too.

p.s. to devs, please remember to release a new version for portal and comments-ui after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants