Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popular info finder #39

Merged
merged 6 commits into from
May 2, 2023
Merged

Conversation

UP2040499
Copy link
Owner

@UP2040499 UP2040499 commented Apr 28, 2023

Added the popular info finder
Further attempts to optimise source aggregator.
Added new functions to entity processor for popular info finder. Created a unit test for the popular info finder.

Took 14 hours 16 minutes

Further attempts to optimise source aggregator.
Added new functions to entity processor for popular info finder.
Created a unit test for the popular info finder.

Took 14 hours 16 minutes
@UP2040499 UP2040499 linked an issue Apr 28, 2023 that may be closed by this pull request
@UP2040499
Copy link
Owner Author

Now need to add functionality for saving the sources that contain the largest number of popular information.

@UP2040499
Copy link
Owner Author

Pylint resutls

Run pylint --fail-under 8 $(git ls-files '*.py')
************* Module auto_osint_v.main
auto_osint_v/main.py:5:0: W0611: Unused import asyncio (unused-import)
************* Module auto_osint_v.popular_information_finder
auto_osint_v/popular_information_finder.py:48:19: W3101: Missing timeout argument for method 'requests.get' can cause your program to hang indefinitely (missing-timeout)
auto_osint_v/popular_information_finder.py:98:12: W0612: Unused variable 'i' (unused-variable)
auto_osint_v/popular_information_finder.py:5:0: C0411: standard import "import itertools" should be placed before "import requests" (wrong-import-order)
************* Module auto_osint_v.sentiment_analyser
auto_osint_v/sentiment_analyser.py:19:0: C0301: Line too long (102/100) (line-too-long)
************* Module auto_osint_v.source_aggregator
auto_osint_v/source_aggregator.py:96:14: E1101: Instance of 'Resource' has no 'cse' member (no-member)
auto_osint_v/source_aggregator.py:152:8: W0612: Unused variable 'join_keywords' (unused-variable)
************* Module auto_osint_v.specific_entity_processor
auto_osint_v/specific_entity_processor.py:30:0: W1404: Implicit string concatenation found in list (implicit-str-concat)
auto_osint_v/specific_entity_processor.py:81:8: W0612: Unused variable 'texts_length' (unused-variable)
auto_osint_v/specific_entity_processor.py:89:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module auto_osint_v.unit_tests.test_popular_information_finder
auto_osint_v/unit_tests/test_popular_information_finder.py:1:0: C0114: Missing module docstring (missing-module-docstring)
auto_osint_v/unit_tests/test_popular_information_finder.py:[7](https://github.com/UP2040499/auto-osint-v/actions/runs/4832771107/jobs/8611963674?pr=40#step:5:8):0: C0115: Missing class docstring (missing-class-docstring)
auto_osint_v/unit_tests/test_popular_information_finder.py:[8](https://github.com/UP2040499/auto-osint-v/actions/runs/4832771107/jobs/8611963674?pr=40#step:5:9):4: C0116: Missing function or method docstring (missing-function-docstring)
auto_osint_v/unit_tests/test_popular_information_finder.py:11:8: C0415: Import outside toplevel (auto_osint_v.file_handler.FileHandler) (import-outside-toplevel)
auto_osint_v/unit_tests/test_popular_information_finder.py:12:8: C0415: Import outside toplevel (auto_osint_v.specific_entity_processor.EntityProcessor) (import-outside-toplevel)
auto_osint_v/unit_tests/test_popular_information_finder.py:17:8: C0415: Import outside toplevel (auto_osint_v.popular_information_finder.PopularInformationFinder) (import-outside-toplevel)
auto_osint_v/unit_tests/test_popular_information_finder.py:1[9](https://github.com/UP2040499/auto-osint-v/actions/runs/4832771107/jobs/8611963674?pr=40#step:5:10):8: W0[10](https://github.com/UP2040499/auto-osint-v/actions/runs/4832771107/jobs/8611963674?pr=40#step:5:11)5: String statement has no effect (pointless-string-statement)
************* Module auto_osint_v.unit_tests.test_specific_entity_processor
auto_osint_v/unit_tests/test_specific_entity_processor.py:15:4: C0[11](https://github.com/UP2040499/auto-osint-v/actions/runs/4832771107/jobs/8611963674?pr=40#step:5:12)6: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.44/10

@UP2040499
Copy link
Owner Author

Need to fix unittest directory on this branch. It conflicts with main and others.
Move from auto-osint-v/auto_osint_v/unittests -> auto-osint-v/unittests

@UP2040499 UP2040499 changed the base branch from main to priority-manager May 2, 2023 14:19
@UP2040499 UP2040499 merged commit c2ef17a into priority-manager May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popular information finder
1 participant