Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDAL to 3.3.0 #64

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

GDAL to 3.3.0 #64

wants to merge 8 commits into from

Conversation

scotthavens
Copy link

@scotthavens scotthavens commented Jul 28, 2021

Another major update to upgrade GDAL to a version from this decade. The docker image now uses the official OSGEO gdal image based on an Ubuntu image. This doesn't really save any size on the docker image as it uses the Ubuntu full to get the netcdf support which is not in the smaller image.

This also updates the requirements to more recent versions which had some minor impacts. Almost all gold files needed to be regenerated but only to update a few attributes with zero impact on the outputs.

Generate topo

  • Newer version of geopandas changed how they report CRS, update to just get the EPSG code
  • Moved the gold tests for different vegetation types to the vegetation test folder
  • Updated the Landfire 1.4.0 and 2.0.0 gold files

Ran the gold_difference script for both Landfire 1.4.0 and 2.0.0. All reported 0 change from main.

GRM

No impact, tests passed

Delineate

There are the most substantial changes but still fairly minor.

  • OGR no longer appears to support the .bna format. Changing this to an approved format worked, the tests use geojson.
  • The gold basin outline changed only in the number of points to represent the polygon (old was 204, new is 206). The overlap below shows that they are exactly on top of each other but represented differently in the shapefile

NOTE: I did not have time to test multiple sub basins for delineate in the geojson or other format.

The red outline is the old gold file, shaded is the new basin outline, point is the basin outlet from the geojson.
image

@scotthavens scotthavens marked this pull request as ready for review July 28, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant