Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a config file #13

Merged
merged 26 commits into from
Mar 12, 2020
Merged

Move to a config file #13

merged 26 commits into from
Mar 12, 2020

Conversation

scotthavens
Copy link
Contributor

Build off @micah-prime start to using a config file. This PR creates a config file that integrates into katana. Changes include:

  • WindNinja class to work with the call to WindNinja_cli
  • Cleaned up the grib handling
  • Better errors from WindNinja_cli
  • Tests cover most of the functionality
  • Moved run_katana to a testable script
  • flake8 passes

micah-prime and others added 23 commits February 18, 2019 16:03
@micah-prime
adding coreconfig and recpies
fd2a7c7
@micah-prime
1. reading in config
de1a1e5 
2. added config to package data
3. still need to parse config in class init
@micah-prime
restructuring init to parse the config file
b5eddae
@micah-prime
updating tests to use config
8434020
@micah-prime
cleaning up tests
1c526e5
@micah-prime @scotthavens
adding coreconfig and recpies
d6c7037
@scotthavens
rebase with master
42682d1
@micah-prime @scotthavens
restructuring init to parse the config file
29fad2d
@micah-prime @scotthavens
updating tests to use config
51df388
@micah-prime @scotthavens
cleaning up tests
5a92dcc
@scotthavens
pinned inicheck
5ea4dc7
@scotthavens
Merge branch 'config' of github.com:USDA-ARS-NWRC/katana into config
0ecbff4
@scotthavens
added to the core config file
fbba705
@scotthavens
seperated out the WindNinja call into it's own class and created cust…
cec9d63 
…om checker for for a raw string
@scotthavens
built a test to catch wind ninja error
50d7e16
@scotthavens
added more tests for the configuration
9340cf9
@scotthavens
updating the popen calls to provide more information and better error…
484b82e 
… handling
@scotthavens
cleaned up the grib cropping, forecast_duration does not do anything …
cb6d1ff 
…so it was removed
@scotthavens
updated readme and the test file
90b026e
@scotthavens
day lists creation, testing and implementation. Testing the make grib
cd9f044
@scotthavens
remove the scripts/run_katana in favor of have a cli function in the …
fccd214 
…framework, added mock tests for the cli command
@scotthavens
flake8 and isort
6ce5a6c
@scotthavens
updated readme and entrypoint, may need to flush out SMRF integration…
01d9b15 
… docs.
@scotthavens scotthavens mentioned this pull request Mar 9, 2020
Open
@scotthavens scotthavens mentioned this pull request Mar 9, 2020
Closed
micahjohnson150
micahjohnson150 suggested changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@micahjohnson150 micahjohnson150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It will be really nice to have this overlaid with a config file. The rewrite on the wind_ninja class looks super clean too. I just had a couple suggestions on the inicheck biz.

katana/CoreConfig.ini Outdated Show resolved Hide resolved
katana/CoreConfig.ini Outdated Show resolved Hide resolved
katana/CoreConfig.ini Show resolved Hide resolved
katana/__init__.py Show resolved Hide resolved
katana/framework.py Outdated Show resolved Hide resolved
katana/framework.py Outdated Show resolved Hide resolved
katana/utils.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
tests/test_base.py Outdated Show resolved Hide resolved
robertson-mark
robertson-mark suggested changes Mar 11, 2020
View reviewed changes
Copy link

@robertson-mark robertson-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this is nice and clean. I have only minor comments/suggestions, mainly to exit if there are inicheck errors.

@scotthavens scotthavens merged commit 1037045 into master Mar 12, 2020
@scotthavens scotthavens deleted the config branch March 12, 2020 17:42
@scotthavens scotthavens mentioned this pull request Mar 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahjohnson150 micahjohnson150 micahjohnson150 approved these changes

@robertson-mark robertson-mark robertson-mark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scotthavens @micahjohnson150 @robertson-mark @micah-prime