Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: native currency routing in routing-api #856

Merged
merged 13 commits into from
Oct 3, 2024
Merged

fix: native currency routing in routing-api #856

merged 13 commits into from
Oct 3, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Oct 2, 2024 •
edited
Loading

No description provided.

@jsy1218 Graphite App
Copy link
Member Author

jsy1218 commented Oct 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 changed the title fix: pool id and incorrect pool native token address fix: native currency routing in routing-api Oct 2, 2024
@jsy1218 jsy1218 marked this pull request as ready for review October 2, 2024 22:00
@graphite-app graphite-app bot requested review from a team and cgkol October 2, 2024 22:01
@graphite-app graphite-app bot requested a review from xrsv October 2, 2024 22:01
cgkol
cgkol reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets please addd a test so we dont miss this next time? or if we add something it gets picked up

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 2, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (10/02/24)

4 reviewers were added and 1 assignee was added to this PR based on 's automation.

jsy1218
jsy1218 commented Oct 2, 2024
View reviewed changes
lib/handlers/schema.ts Outdated Show resolved Hide resolved
@jsy1218 jsy1218 requested a review from cgkol October 3, 2024 15:26
cgkol
cgkol reviewed Oct 3, 2024
View reviewed changes
test/mocha/e2e/quote.test.ts Show resolved Hide resolved
test/mocha/e2e/quote.test.ts Show resolved Hide resolved
@socket-security Socket Security
Copy link

socket-security bot commented Oct 3, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] Transitive: environment, eval, filesystem, network, shell +100 114 MB

🚮 Removed packages: npm/@uniswap/[email protected]

View full report↗︎

@jsy1218 Graphite App
Copy link
Member Author

jsy1218 commented Oct 3, 2024 •
edited
Loading

Merge activity

  • Oct 3, 2:12 PM EDT: @jsy1218 started a stack merge that includes this pull request via Graphite.
  • Oct 3, 2:12 PM EDT: @jsy1218 merged this pull request with Graphite.

@jsy1218 jsy1218 merged commit ba240b2 into main Oct 3, 2024
8 checks passed
@jsy1218 jsy1218 deleted the siyujiang/fix-v4-pool-id-pool-native-token-address branch October 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgkol cgkol cgkol approved these changes

@xrsv xrsv Awaiting requested review from xrsv

Assignees

@jsy1218 jsy1218

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsy1218 @cgkol @unicorn-here