Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue 3 #4

wants to merge 2 commits into from

Conversation

sfontes
Copy link

@sfontes sfontes commented Oct 30, 2018

Correcting the Issue 3

@sfontes
Updated to latest AWS SDK
adccf1a 
The version of the SDK used is not compatible with new regions,
updating.
@sfontes
Removed requirement of access key and secret key
e67c05f 
Access key and Secret key needed to be defined in the pom file and when
they were not the pom file would not run. Since the access key and
secret key can be optional I have defined it as optional.

Fixes Upplication#3
@sfontes
Copy link
Author

sfontes commented Oct 30, 2018

Thank you for reviewing, are you able to merge to master and do a new release?

@erizocosmico
Copy link

erizocosmico commented Oct 30, 2018 via email

velo referenced this pull request in velo/s3-download-maven-plugin Mar 16, 2023
@velo
Merge pull request #4 from velo/dependabot/maven/org.sonatype.plugins…
d195190 
…-nexus-staging-maven-plugin-1.6.13

Bump nexus-staging-maven-plugin from 1.6.8 to 1.6.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erizocosmico erizocosmico erizocosmico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sfontes @erizocosmico