Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT PuffinnLSH #45

Merged
merged 10 commits into from
Oct 28, 2019
Merged

FEAT PuffinnLSH #45

merged 10 commits into from
Oct 28, 2019

Conversation

VarIr
Copy link
Owner

@VarIr VarIr commented Oct 11, 2019

Due to upstream improvements in puffinn, should now work on MacOS.
Also, the num_threads argument has been removed from Index.rebuild().

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@0e1d230). Click here to learn what that means.
The diff coverage is 69.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #45   +/-   ##
==========================================
  Coverage           ?   98.59%           
==========================================
  Files              ?       54           
  Lines              ?     4428           
  Branches           ?      493           
==========================================
  Hits               ?     4366           
  Misses             ?       37           
  Partials           ?       25
Impacted Files Coverage Δ
skhubness/utils/platform.py 55.55% <0%> (ø)
skhubness/neighbors/tests/test_lof.py 98.03% <100%> (ø)
skhubness/neighbors/base.py 95.37% <100%> (ø)
skhubness/neighbors/tests/test_lsh.py 96.42% <100%> (ø)
skhubness/neighbors/tests/test_neighbors.py 99.68% <100%> (ø)
skhubness/neighbors/lsh.py 92.57% <62.96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1d230...28c67c8. Read the comment docs.

@VarIr VarIr mentioned this pull request Oct 11, 2019
2 tasks
@VarIr
Copy link
Owner Author

VarIr commented Oct 11, 2019

Closes #36

@VarIr VarIr merged commit 3e28206 into develop Oct 28, 2019
@VarIr VarIr deleted the newbaseest branch October 28, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants