Bugfix: Memory leak in diff plugin #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff plugin did not run each iteration in an isolated scope so cleanup destructors where not being called. Additionally registry cache was not installed in the root scope which limited its usefulness in sub queries mostly leading to cache misses. The default behaviour of TTL cache is to extend the ttl on each Get() operation. This is hardly ever what we want because then some cached items will never expire.
scudette
added a commit
that referenced
this pull request
Jun 30, 2024
The diff plugin did not run each iteration in an isolated scope so cleanup destructors where not being called. Additionally registry cache was not installed in the root scope which limited its usefulness in sub queries mostly leading to cache misses. The default behaviour of TTL cache is to extend the ttl on each Get() operation. This is hardly ever what we want because then some cached items will never expire.
scudette
added a commit
that referenced
this pull request
Jun 30, 2024
The diff plugin did not run each iteration in an isolated scope so cleanup destructors where not being called. Additionally registry cache was not installed in the root scope which limited its usefulness in sub queries mostly leading to cache misses. The default behaviour of TTL cache is to extend the ttl on each Get() operation. This is hardly ever what we want because then some cached items will never expire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff plugin did not run each iteration in an isolated scope so cleanup destructors where not being called.
Additionally registry cache was not installed in the root scope which limited its usefulness in sub queries mostly leading to cache misses.
The default behaviour of TTL cache is to extend the ttl on each Get() operation. This is hardly ever what we want because then some cached items will never expire.