Ensure that server VQL plugins only work on the server #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by VQL plugins that change server state to make sure the VQL query is running inside a valid frontend. Since VQL queries can run with the `velociraptor query` command it is possible they are just running on the same server as Velociraptor (and therefore the data store is still visible) but it is important to make sure the datastore is not modified outside the proper frontend process. This is because many services are now caching data in memory and changing the underlying data stored will not be immediately visible to them causing confusion to users.
scudette
added a commit
that referenced
this pull request
Jun 30, 2024
This is used by VQL plugins that change server state to make sure the VQL query is running inside a valid frontend. Since VQL queries can run with the `velociraptor query` command it is possible they are just running on the same server as Velociraptor (and therefore the data store is still visible) but it is important to make sure the datastore is not modified outside the proper frontend process. This is because many services are now caching data in memory and changing the underlying data stored will not be immediately visible to them causing confusion to users.
scudette
added a commit
that referenced
this pull request
Jun 30, 2024
This is used by VQL plugins that change server state to make sure the VQL query is running inside a valid frontend. Since VQL queries can run with the `velociraptor query` command it is possible they are just running on the same server as Velociraptor (and therefore the data store is still visible) but it is important to make sure the datastore is not modified outside the proper frontend process. This is because many services are now caching data in memory and changing the underlying data stored will not be immediately visible to them causing confusion to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by VQL plugins that change server state to make sure the VQL query is running inside a valid frontend. Since VQL queries can run with the
velociraptor querycommand it is possible they are just running on the same server as Velociraptor (and therefore the data store is still visible) but it is important to make sure the datastore is not modified outside the proper frontend process.This is because many services are now caching data in memory and changing the underlying data stored will not be immediately visible to them causing confusion to users.