Technical debt/certificate search tests and fixes an issue with empty Common Name #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EduardoVV
commented
Sep 9, 2022
EduardoVV
commented
- Adds missing tests for Search valid certificate #252
- Fixes an issue with empty cn and sans on VaaS
EduardoVV
requested review from
rvelaVenafi,
marcos-albornoz and
luispresuelVenafi
as code owners
luispresuelVenafi
changed the title
marcos-albornoz
approved these changes
Sep 9, 2022
luispresuelVenafi
approved these changes
Sep 9, 2022
EduardoVV
force-pushed
the
technical-debt/certificate-search-tests
branch
from
728e69d
to
6d810ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.