build(scripts): type runInstaller
#1663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only `//scripts/build/buildWeb.mjs` was failing lint.
bb010g
changed the title
runInstaller
The ETag file could be made inaccessible between `existsSync()` and `readFileSync()`.
|
|
|
please avoid redundant style changes / unnecessary refactors, this contributes nothing relevant and just pollutes history and wastes both of our time |
Could this be reopened? It actually fixes a handful of bugs, or at least brings a few things to type compliance. It's also been refactored to no longer land on top of on #1662. Ideally, this would also fix hang I'm running into with this script on Windows, but I'm still debugging that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1661 (due to use of the
.mtsfile extension).