-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IncludeFunctionRule
in default standard fixer
#218
Conversation
Can you list some example of codebase ? |
ref https://twitter.com/lyrixx/status/1765694838756807153 for the ones i had in my mind could event be usefull to propose to add such tool in the symfony/symfony codebase, as there is the php cs fixer already ^^ |
IncludeFunctionRule
in default standard fixerIncludeFunctionRule
in default standard fixer
IncludeFunctionRule
in default standard fixerIncludeFunctionRule
in default standard fixer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll think a little before merging this.
I dunno if I want to provide this by default.
Until the tag is deprecated, this might be considered as very opinionated...
Also, I could introduce another standard for such rules...
do you think its worth it an issue is opened on the symfony/twig repos for the deprecation?
indeed it can be seen like this, but its the real usage in fine |
Sure, see https://twitter.com/fabpot/status/1765719169662648337 |
I've read this of course, thus this PR does doing this will make this PR advance and your comment thank you |
Sure, I think it's a good idea to propose a PR on twig.
If the deprecation is accepted on twig repository, I'll merge 100% this PR. |
I've just opened an issue twigphp/Twig#4067 lets see how it goes 👍🏻 also just opened a PR at symfony repo to add this tool if it is worth it |
hey,
I know there is https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/docs/configuration.md
but I see a lot of codebase going to this, which is more correct in twig
wdyt of it being standard?