Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-1448: Added the ability to unregister meta fields by name, templateUrl or a custom search predicate callback. #2813

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Jul 1, 2024

Description

Original PR by @SamBauwensPM: #2812

Added the ability to unregister meta fields by name, templateUrl or a custom search predicate callback

We originally did that in a custom module of ours, and @EugeneOkhriemnko suggested I create a PR here so everyone can benefit.

Since there is no real method overloading in js, I did some _.isFunction magic to allow the same method ~group to accept the 3 different types of values for metaFieldToFind: name, function callback or object reference.

I added an error message because I think it's better t have an error than to silently not remove a field, but that could be considered a breaking change since the previous code didn't throw an error, if preferred this could be changed so that it only throws on error if metaFieldDescription, or not throw at all, or having this error throwing behaviour configured somewhere I don't know.

I tried to stay backwards compatible with the way unregisterMetaFields worked before, i.e it accepts an object reference in metaFieldToFind.## References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-1448

Artifact URL:

Image tag:
3.839.0-pr-2813-72ba-vcst-1448-72baae9b

Copy link

sonarcloud bot commented Jul 1, 2024

@OlegoO OlegoO merged commit ad18c92 into dev Jul 1, 2024
8 checks passed
@OlegoO OlegoO deleted the VCST-1448 branch July 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants