-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pook to v2 #4582
base: main
Are you sure you want to change the base?
Update pook to v2 #4582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indexer_worker
lockfile updates packages other than pook
. Just making sure it's known to the reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version bumps to boto3,botocore,filelock,and ipython in the indexer worker lockfile seem like good updates to make anyway so LGTM.
Ah, I ran plain |
cda3225
to
ce84d37
Compare
Description
Pook released v2 today. I've updated all but the ingestion server because it will soon be deleted.
Testing Instructions
CI must pass. Review pook's release notes and confirm everything is covered that needs to be changed for v2: https://github.com/h2non/pook/releases/tag/v2.0.0
Checklist
Update index.md
).main
) or a parent feature branch../ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
./ov just catalog/generate-docs media-props
for the catalog or
./ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin