-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using Insight #26
Conversation
Reviewer's Guide by SourceryThis pull request refactors the LCZero model wrapper to use the NNsight library, renaming the main class from File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Xmaster6y - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Closes #24
Summary by Sourcery
This pull request refactors the codebase to replace the
ModelWrapper
class with the newLczeroModel
class, which extendsNNsight
. It also introduces new XAI lenses (ProbingLens
,ActivationLens
, andPatchingLens
) and removes deprecated files and modules.LczeroModel
class extendingNNsight
for model handling.ProbingLens
class for probing-based XAI methods.ActivationLens
class for activation-based XAI methods.PatchingLens
class for patching-based XAI methods.ModelWrapper
withLczeroModel
across the codebase for improved model handling.LczeroModel
.Flow
class to extendLczeroModel
instead ofModelWrapper
.