Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation typos #29

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Documentation typos #29

merged 3 commits into from
Jul 3, 2024

Conversation

Xmaster6y
Copy link
Owner

@Xmaster6y Xmaster6y commented Jul 3, 2024

Summary by Sourcery

This pull request updates various Colab links in the documentation to point to the correct repository paths and adds a note about the installation time for lc0 binaries in the convert-official-weights.ipynb notebook.

  • Documentation:
    • Updated Colab links in multiple documentation files to point to the correct repository paths.
    • Added a note about the installation time for lc0 binaries in the convert-official-weights.ipynb notebook.

Copy link
Contributor

sourcery-ai bot commented Jul 3, 2024

Reviewer's Guide by Sourcery

This pull request primarily addresses documentation typos by updating Colab links to point to the correct repository paths. Additionally, it removes unnecessary output logs and streamlines the installation process in the convert-official-weights.ipynb notebook, and adds a note about the time required to install lc0 binaries.

File-Level Changes

Files Changes
docs/source/notebooks/features/convert-official-weights.ipynb
docs/source/notebooks/features/move-prediction.ipynb
docs/source/notebooks/tutorials/evidence-of-learned-look-ahead.ipynb
docs/source/notebooks/tutorials/piece-value-estimation-using-lrp.ipynb
docs/source/notebooks/walkthrough.ipynb
Updated Colab links to point to the correct repository path.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Xmaster6y - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Xmaster6y Xmaster6y merged commit 6aa0266 into main Jul 3, 2024
1 check passed
@Xmaster6y Xmaster6y deleted the typos branch July 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant