Add camera view editing mode #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Apr 23, 2024
| // Mouse was released last frame so the adjustment cannot be active. | ||
| assert!(self.camera_view_adjustment.is_none()); | ||
|
|
||
| // There are no other adjustments in the camera editor at the moment; and anyhow |
There was a problem hiding this comment.
I guess this comment needs an update here and in the other place
There was a problem hiding this comment.
What kind of comment change do you prefer here? Straight up deletion?
src/modules/tas_studio/editor/mod.rs
Outdated
| @@ -296,6 +305,23 @@ struct InsertCameraLineAdjustment { | |||
| did_split: bool, | |||
| } | |||
|
|
|||
| /// Camera view edit modes. | |||
| /// | |||
| /// `Alt` adjusts differently for different kinds of line. | |||
There was a problem hiding this comment.
Could you describe here what exactly it does?
There was a problem hiding this comment.
Alt is in case you want the result to be something like target yaw offset or target yaw velocity lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
I think the organizing is a bit weird. Not sure how to go around that because this needs the game itself to work.
Need YaLTeR/BunnymodXT#520 to have it work.