Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release & script, and move admin creation before daemon #10

Open
wants to merge 4 commits into
base: admin_creation
Choose a base branch
from

Conversation

mayel
Copy link

@mayel mayel commented Apr 16, 2024

No description provided.

@mayel
Copy link
Author

mayel commented Apr 16, 2024

hold on, moving the admin creation means it doesn't have .env loaded, working on that

@mayel
Copy link
Author

mayel commented Apr 16, 2024

@lapineige can we test this?

@lapineige
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

✌️
Test Badge

@mayel
Copy link
Author

mayel commented Apr 16, 2024

hmm, so maybe the environment of the install script is not shared with the app when run by ynh_exec_warn_less

@mayel
Copy link
Author

mayel commented Apr 16, 2024

the reason I moved it to before the daemon (and using eval which starts the app, instead of rpc which tries to connect to an already running app) is that otherwise without some way to know the app has finished starting and is in a ready state the user creation may fail to early

@lapineige
Copy link
Member

otherwise without some way to know the app has finished starting and is in a ready state the user creation may fail to early

The start command config should be there to wait any "I finished starting" line. Waiting for that log : https://github.com/bonfire-networks/bonfire-yunohost/blob/use-release/scripts/install#L126

@mayel
Copy link
Author

mayel commented Apr 17, 2024

aha!

@lapineige
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@yunohost-bot
Copy link
Contributor

📚 🪱
Test Badge

@lapineige
Copy link
Member

Same errors apparently.
These messages are quite confusing for me :(

@lapineige
Copy link
Member

Could you update to latest release https://github.com/bonfire-networks/bonfire-app/releases/tag/v0.9.10-beta.75 ?
I can't edit the branch myself.

@mayel
Copy link
Author

mayel commented May 31, 2024

@lapineige done :)

@lapineige
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@yunohost-bot
Copy link
Contributor

Living in the future, are we?
Test Badge

@lapineige
Copy link
Member

Already a new release in the meantime 😅
Is that necessary for the adsf just issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants