Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get IAM Credential from Metadata API, Fix #10 #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Get IAM Credential from Metadata API, Fix #10 #12

wants to merge 3 commits into from

Conversation

fuyufjh
Copy link

@fuyufjh fuyufjh commented Dec 13, 2016 •
edited
Loading

Fix #10

@a3linux
Copy link
Owner

a3linux commented Jan 12, 2017

I don't understand very well with the "Fetch IAM" commit at this time, give me more time to read and test the code before merge the PR.
Thanks and it looks pretty good.

@a3linux
Copy link
Owner

a3linux commented Mar 23, 2017

Reviewed this again.
I can NOT merge it at this time. I want to test it, especially test with AWS access/secret key mode without IAM role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuyufjh @a3linux