Cast event pitches as integers #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 8 8
Lines 157 157
Branches 19 19
=======================================
Hits 137 137
Misses 15 15
Partials 5 5
Continue to review full report at Codecov.
|
|
Ok got the integer casting issue resolved, although I have uncovered some issues with the CI build (#21 )which will be addressed in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
miditimedependency saves pitch info usingstruct.pack('>B',event.pitch), which requires the second argument to be an integer. This is fixed by casting numbers in the composer matrix to type int.fixes #19