Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported for Python 3 and Newer Zim Versions #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thislight
Copy link

Finished works:

  • code ported to python 3 by 2to3 (see setup.py)
  • rewrite plug-in logic for newer Zim versions (see class GnomeShellSearch)

I have tested it on GNOME 3.36.4 with Zim 0.73.2.

@sojusnik
Copy link

sojusnik commented Aug 13, 2020

Great news, thanks!

Does this searches for note titles and not the content to make the search faster?

@thislight
Copy link
Author

thislight commented Aug 14, 2020

To @sojusnik

Does this searches for note titles and not the content to make the search faster?

It doesn't. I just try to make it to be available again. But looks like Zim's built-in search doesn't support only search in titles.

@sojusnik
Copy link

But looks like Zim's built-in search doesn't support only search in titles.

It actually does! Use Name: for that in the search, as described in help. But it's much better to use the "jump to…" search (Ctrl + j), because you'll get instant results as the pages are already cached (or something like that).

Implementing that would be much better from an UX point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants