This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Fix crash when called without --history-file #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acheong08
approved these changes
May 27, 2023
|
Yes. This fixes it |
|
Thank you very much for your patience and quick action. I'm going to document the change in the README. If I had done that before asking for a PR I would have catched the error. Lesson learned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for merging this feature but I just realized I broke the program. I'm very sorry.
I haven't done much Python so I didn't know calling a function with unexpected arguments would produce an error. I should have tested the program more. I think this fixes it but please confirm.